[0.2] Backport #4158 and bump versions to -beta1 #4159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While its somewhat sad to do, we didn't really make the progress we wanted on dual funded channels in 0.2, and thus aren't super confident in them. Further, because we still don't support actually contributing inputs to an inbound channel nor outbound v2 channel opens there's not really any reason to support them. Thus, we simply re-cfg-gate them here for 0.2.
It seems new rustc removed this feature, hopefully its available upstream but either way it caused the 0.1.6 docs.rs build to fail. Backport of 68e4314
This bumps `lightning` to 0.2-beta1, `lightning-invoice` to 0.34-beta1, `lightning-types` to 0.3-beta1, and `lightning-dns-resolver` to 0.3-beta1. While `lightning-types` really doesn't entirely merit a version bump here (we almost entirely just added features, which isn't a breaking change), we removed a few redundant feature flag modifying methods, which technically broke semver. Hopefully the next version will be able to avoid that. As a result of the `lightning-types` bump, `lightning-invoice` also gets bumped, though it would otherwise not need it.
|
I've assigned @tankyleo as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4159 +/- ##
==========================================
- Coverage 88.79% 88.77% -0.03%
==========================================
Files 180 180
Lines 136553 136566 +13
Branches 136553 136566 +13
==========================================
- Hits 121259 121236 -23
- Misses 12494 12533 +39
+ Partials 2800 2797 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.